Oh no! Where's the JavaScript?
Your Web browser does not have JavaScript enabled or does not support JavaScript. Please enable JavaScript on your Web browser to properly view this Web site, or upgrade to a Web browser that does support JavaScript.
Not a member yet? Click here to register.
Forgot Password?

viewthread little error

Asked Modified Viewed 2,125 times
G
GameAction
G
  • Member, joined since
  • Contributed 50 posts on the community forums.
  • Started 2 threads in the forums
  • Started this discussions
asked
Member

after last update in svn n.863 i've noticed a trivial error at line 277

<a href='../profile.php?lookup=".$data['user_id']."'>


i think that should be

<a href='".BASEDIR."profile.php?lookup=".$data['user_id']."'>
0 replies

7 posts

W
Wooya
W
Wooya 10
PHP-Fusion DEV Team
It's not a bug, it's undocumented feature...
  • Senior Member, joined since
  • Contributed 205 posts on the community forums.
  • Started 11 threads in the forums
answered
Senior Member

Quote

GameAction wrote:
after last update in svn n.863 i've noticed a trivial error at line 277

<a href='../profile.php?lookup=".$data['user_id']."'>


i think that should be

<a href='".BASEDIR."profile.php?lookup=".$data['user_id']."'>


It's not an error.
0 replies
G
GameAction
G
  • Member, joined since
  • Contributed 50 posts on the community forums.
  • Started 2 threads in the forums
  • Started this discussions
answered
Member

but it has to be corrected or not??
if not why?
0 replies
F
Falk
F
Falk 148
Need help?, Having trouble?
• View our Documentation for Guides, Standards and Functions
• Name and Organize your Topics and Content correctly in the corresponding Forums for best support results
• Attaching Log Files and Screenshots when reporting issues will help
• Provide with an URL to live example if one exists
• Please read the How to Report an Error post
• Please read and comply with the Code of Conduct

(¯·._.·(¯°·._.·°º*[ Project Manager ]*º°·._.·°¯)·._.·¯)
  • Super Admin, joined since
  • Contributed 6,201 posts on the community forums.
  • Started 639 threads in the forums
  • Answered 12 questions
answered
Super Admin

Both methods work fine.
0 replies
G
GameAction
G
  • Member, joined since
  • Contributed 50 posts on the community forums.
  • Started 2 threads in the forums
  • Started this discussions
answered
Member

i suppose it has to be changed because everywhere is used in that way, but as you said both methods work fine so make it the way you like ;)
Edited by GameAction on 18-07-2008 18:41,
0 replies
M
muscapaul
M
Paul

Time flies like an arrow, fruit flies like banana (Groucho Marx)

Sites: Diptera.info (site owner); Online-Keys.net (site owner); Sciomyzidae.info (site co-owner); muscapaul.com (defunct; site owner)
  • Veteran Member, joined since
  • Contributed 1,075 posts on the community forums.
  • Started 8 threads in the forums
answered
Veteran Member

Quote

GameAction wrote:
i suppose it has to be changed because everywhere is used in that way

Strictly speaking it would seem as if you are right (and I guess it does make som sens) but in several of the core pages the links are relative compared to the folders as well in as much that they are all called from the root (so not BASEDIR or ../ is necessary). viewthread.php is always at the same 'relative' distance from profile.php so there is no need to treat it differently from all files that link to eachother from the root...
0 replies
G
GameAction
G
  • Member, joined since
  • Contributed 50 posts on the community forums.
  • Started 2 threads in the forums
  • Started this discussions
answered
Member

i see that when is necessary a call to maincore.php is used ../ and than in rest of code is used BASEDIR ADMIN and so on...
in this case profile is not in the same folder so is needed ../ or BASEDIR, it's the same, but if elsewhere is used BASEDIR why don't use it here?
but at the end, no one care about a ../ or BASEDIR in 1 line of code... :P it's just a trivial error as i said in the first post :)
0 replies
B
Basti
B
Basti 10
[PHP-Fusion Crew Member & Admin from June 2008 - December 2010]

http://basti2web.de - Support Site for my infusions
  • Veteran Member, joined since
  • Contributed 1,099 posts on the community forums.
  • Started 32 threads in the forums
answered
Veteran Member

Quote

it's just a trivial error as i said in the first post

No, it is not any error. It is an optimisation!
Edited by Basti on 19-07-2008 13:36,
0 replies

Labels

None yet

Statistics

  • Views 0 views
  • Posts 7 posts
  • Votes 0 votes
  • Topic users 5 members

5 participants

F
F
Falk 148
Need help?, Having trouble?
• View our Documentation for Guides, Standards and Functions
• Name and Organize your Topics and Content correctly in the corresponding Forums for best support results
• Attaching Log Files and Screenshots when reporting issues will help
• Provide with an URL to live example if one exists
• Please read the How to Report an Error post
• Please read and comply with the Code of Conduct

(¯·._.·(¯°·._.·°º*[ Project Manager ]*º°·._.·°¯)·._.·¯)
  • Super Admin, joined since
  • Contributed 6,201 posts on the community forums.
  • Started 639 threads in the forums
  • Answered 12 questions
M
M
Paul

Time flies like an arrow, fruit flies like banana (Groucho Marx)

Sites: Diptera.info (site owner); Online-Keys.net (site owner); Sciomyzidae.info (site co-owner); muscapaul.com (defunct; site owner)
  • Veteran Member, joined since
  • Contributed 1,075 posts on the community forums.
  • Started 8 threads in the forums
G
G
  • Member, joined since
  • Contributed 50 posts on the community forums.
  • Started 2 threads in the forums
  • Started this discussions
W
W
Wooya 10
PHP-Fusion DEV Team
It's not a bug, it's undocumented feature...
  • Senior Member, joined since
  • Contributed 205 posts on the community forums.
  • Started 11 threads in the forums
B
B
Basti 10
[PHP-Fusion Crew Member & Admin from June 2008 - December 2010]

http://basti2web.de - Support Site for my infusions
  • Veteran Member, joined since
  • Contributed 1,099 posts on the community forums.
  • Started 32 threads in the forums

Notifications

Track thread

You are not receiving notifications from this thread.

Related Questions

Not yet