Shoutbox Problems: PHPFusion 6 Support

Home
Search

Oh no! Where's the JavaScript?
Your Web browser does not have JavaScript enabled or does not support JavaScript. Please enable JavaScript on your Web browser to properly view this Web site, or upgrade to a Web browser that does support JavaScript.

is there some kind of bug that would stop members shouting in the Shoutbox sometime members have to re shout several times before their shout have been posted i have tried to reload the Shoutbox panel but the problem remains ?

0 replies

Hi Druid,
there might be something there. I just noticed the same thing on one site running v6.01.11.
This could be related to the last upgrade, I had no time to look into it, but we might need to look into it. Does anybody else have the same experience?

0 replies

yes this problem has only started to occur after my last upgrade to v6.01.11. also i am having trouble with visiting Custom Pages instead of the link redirecting them to the Custom page it logs members out but if they click on the Back button then they continue to be logged on :|

0 replies

Yes, I have seen the shoutbox failure on lots of sites now. It seems to fail when you read a forum thread (viewthread.php) and then type a message in the shoutbox.

Edit: The shout is stored on this site though, but after you post the site redirects to http://www.php-fusion.co.uk/forum/

Edited by Ken on 09-08-2007 14:31, 17 y

0 replies

Yup,

It's broken in 6.01.11.

Seems like when you are on an extended url containing &, then shout will fail and you get redirected.

0 replies

This is a bug caused by the function cleanurl() introduced in 6.01.11.

Replacing & with &.amp; works for urls displayed as html, but it will not work for urls passed directly to the browser.

As example http://www.php-fusion.co.uk/forum/viewthread.php?forum_id=39&.amp;thread_id=17737

will not lead to this thread but redirect to forum index.

Note: remove the . in above &.amp; It's put there in order not to enterpretet the entity.

Digi needs to fix this.

0 replies

If the sanitising of $_SERVER globals are kept as they are in 6.01.11, then i'll suggest this change to \infusions\shoutbox_panel\shoutbox_panel.php:

Find:

Code Download source

fallback(FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));

Replace with:

Code Download source

      // fallback(FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));
      fallback(str_replace("&#amp;","&",FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : "")));

Find:

Code Download source

echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".str_replace("&","&#amp;",FUSION_QUERY) : "")."'>

Replace with:

Code Download source

   // echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".str_replace("&","&#amp;",FUSION_QUERY) : "")."'>
   echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : "")."'>

Remove # in code to get correct entity for &#amp;

0 replies

And similar applies to the infusions\member_poll_panel\member_poll_panel.php

Find:

Code Download source

header("Location: ".FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));

Replace with:

Code Download source

      // header("Location: ".FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));
      header("Location: ".str_replace("&#amp;","&",FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : "")));

Again remove # in code to get correct entity for &#amp;

0 replies

Falk

answered 19 Aug 2007 at 09:04 PM

Super Admin

In v7 we have alterations to the fallback and redirect functions in maincore.php, simply replace:

Code Download source

// Redirect browser using the header function
function redirect($location, $type="header") {
   if ($type == "header") {
      header("Location: ".$location);
   } else {
      echo "<script type='text/javascript'>document.location.href='".$location."'</script>\n";
   }
}

// Fallback to safe area in event of unauthorised access
function fallback($location) {
   header("Location: ".$location);
   exit;
}

With:

Code Download source

// Redirect browser using the header function
function redirect($location, $type="header") {
   if ($type == "header") {
      header("Location: ".str_replace("&amp;", "&", $location));
   } else {
      echo "<script type='text/javascript'>document.location.href='".str_replace("&amp;", "&", $location)."'</script>\n";
   }
}

// Fallback to safe area in event of unauthorised access
function fallback($location) {
   header("Location: ".str_replace("&amp;", "&", $location));
   exit;
}

Edited by Falk on 20-08-2007 01:41, 17 y

0 replies

I tried your suggestion Nick, but it seems that it didn't kill the bug :|

Edited by Ken on 20-08-2007 01:01, 17 y

0 replies

Falk

answered 20 Aug 2007 at 01:40 AM

Super Admin

It didn't come up right, fixed it now

0 replies

i have also tried the code and at first it seemed to be working fine but this morning same problems

0 replies

Falk

answered 20 Aug 2007 at 03:05 PM

Super Admin

Well it SHOULD fix the problem.

0 replies

I tested this, but you are still redirected to forum index when you are located in a forum thread and try to post a shout or a vote in a poll?

0 replies

Falk

answered 20 Aug 2007 at 06:16 PM

Super Admin

Hmm, ok, in shoutbox_panel.php, look for:

Code Download source

echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".str_replace("&","&amp;",FUSION_QUERY) : "")."'>

Replace with:

Code Download source

echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : "")."'>

Edited by Falk on 20-08-2007 18:33, 17 y

0 replies

This returns:

Quote

Not Found

The requested URL /forum/viewthread.phpforum_id=6&thread_id=46 was not found on this server.

0 replies

Falk

answered 20 Aug 2007 at 06:33 PM

Super Admin

Try now, small error.

0 replies

This fixed the shoutbox_panel.php

Now you just need to change the member_poll_panel.php to use:

Code Download source

fallback(FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));

Instead of:

Code Download source

header("Location: ".FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));

0 replies

@WEC, @Digitanium:
had this post the correct code -for shoutbox- (...without #)?

edit: because i mod like this:

Code Download source

...

      if ($settings['version'] == "6.01.11") {
      fallback(str_replace("&amp;","&",FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : "")));
      } else {
      fallback(FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : ""));
      }

...

   if ($settings['version'] == "6.01.11") {
   echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".FUSION_QUERY : "")."'>";
   } else {
   echo "<form name='chatform' method='post' action='".FUSION_SELF.(FUSION_QUERY ? "?".str_replace("&","&amp;",FUSION_QUERY) : "")."'>";
   }
   echo "

...

Edited by lelebart on 21-08-2007 23:10, 17 y

0 replies

Category Forum

Bugs and Errors - 6

Labels

None yet

Statistics

Views 0 views
Posts 18 posts
Votes 0 votes
Topic users 6 members

0 participants

Notifications

Track thread

You are not receiving notifications from this thread.

Shoutbox Problems

18 posts

PHPFusion

Resources

Community

Development