smiley parse issue in forum
Asked Modified Viewed 1,657 times
asked
Version 7.0.4
Searched: yes
Smiley was set as ;S (semi-colon, cap. ess) but parser was also accepting ' (an apostrophe) for that smilie.
I had a look at the preg but couldn't see the issue, changing the smiley code to ;;S fixed it.
other issues exist including;
smiley set as p
- shows the smiley for
smiley set asP - shows the smiley for
etc
I guess the code is doing a looped preg and is checking them in database order. Maybe they should be ordered by strlen to lessen early hits? or allow user ordering.
Searched: yes
Smiley was set as ;S (semi-colon, cap. ess) but parser was also accepting ' (an apostrophe) for that smilie.
I had a look at the preg but couldn't see the issue, changing the smiley code to ;;S fixed it.
other issues exist including;
smiley set as p
- shows the smiley for smiley set as
P - shows the smiley for etc
I guess the code is doing a looped preg and is checking them in database order. Maybe they should be ordered by strlen to lessen early hits? or allow user ordering.
answered
to correct the second issue is as easy as changing line 385
From:
To:
It's adds about 10% on to the SQL exe time but that's nothing in the grand scheme of things.
From:
Code Download source
$result = dbquery("SELECT * FROM ".DB_SMILEYS);To:
Code Download source
$result = dbquery("SELECT * FROM ".DB_SMILEYS." order by char_length(smiley_code) DESC");It's adds about 10% on to the SQL exe time but that's nothing in the grand scheme of things.
Category Forum
Suspected Bugs and Errors - 8Labels
None yet
Statistics
- Views 0 views
- Posts 1 post
- Votes 0 votes
- Topic users 1 member
1 participant
moozaad 10
- Newbie, joined since
- Contributed 5 posts on the community forums.
- Started 2 threads in the forums
- Started this discussions
Notifications
Track thread
You are not receiving notifications from this thread.
Related Questions